summaryrefslogtreecommitdiff
path: root/module/oop
diff options
context:
space:
mode:
authorMichael Käppler <xmichael-k@web.de>2024-04-02 08:58:52 +0200
committerLudovic Courtès <ludo@gnu.org>2024-05-06 11:51:53 +0200
commit80d4055e4213763e2d3a0bfcc39d6b55c52f5415 (patch)
treeeee3e23a22d33a3eed23e9f83814f0a600f59728 /module/oop
parent57a889b7282dab303c4cdc49cccbbe22f961bd1c (diff)
downloadguile-80d4055e4213763e2d3a0bfcc39d6b55c52f5415.tar.gz
Fix error messages containing format strings
The builtin primitive procedure `error` takes an optional message and a list of arguments to include into the error message. These args are formatted with `~S` and appended to the error message, so that an example call of `(error "Wrong argument: " 42)` results in the output "Wrong argument: 42" If format strings occur in the message itself, however, they are escaped. Thus a call like `(error "Wrong argument: ~a" 42)` is rendered as "Wrong argument: ~a 42" Some callers did not take this behavior into account, leading to confusing error messages. Changing the behavior of `error` to be both backwards-compatible and accept also format strings inside messages is not straightforward, because it would have to handle escaped `~` characters as well. Therefore, fix `error` call sites using format strings to use `format` before calling out to `error`. The following files are affected: * module/ice-9/format.scm (format) * module/ice-9/r6rs-libraries.scm (resolve-r6rs-interface) * module/oop/goops.scm (make) * module/srfi/srfi-37.scm (Comment at the beginning of file) * module/system/base/compile.scm (call-once) * module/system/repl/command.scm (break, tracepoint) * module/system/repl/common.scm (repl-default-options) * module/system/vm/traps.scm (arg-check, trap-at-source-location) There are a couple of further call sites that were left unchanged, either because they are using their own `error` procedure: * module/ice-9/read.scm * module/ice-9/command-line.scm or are not referenced from other modules: * module/system/base/lalr.upstream.scm: * module/sxml/upstream/assert.scm: * module/sxml/sxml-match.ss: Signed-off-by: Ludovic Courtès <ludo@gnu.org>
Diffstat (limited to 'module/oop')
-rw-r--r--module/oop/goops.scm2
1 files changed, 1 insertions, 1 deletions
diff --git a/module/oop/goops.scm b/module/oop/goops.scm
index de5e8907d..8ed68694c 100644
--- a/module/oop/goops.scm
+++ b/module/oop/goops.scm
@@ -542,7 +542,7 @@ followed by its associated value. If @var{l} does not hold a value for
;; Boot definition.
(define (make class . args)
(unless (memq <slot> (class-precedence-list class))
- (error "Unsupported class: ~S" class))
+ (error (format #f "Unsupported class: ~S" class)))
(make-slot class args))
;; Boot definition.