From d804177be4525feb517feb63ca09502d187fc016 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Tue, 14 Apr 2020 22:08:45 +0200 Subject: bitvector-bit-set? / bitvector-bit-clear? replace bitvector-ref This is an opportunity to make a new interface that can be more efficient in 3.0 (because no generic array support), easier to read (no need for 'not'), and more consistent with other bitvector interfaces. * NEWS: Add entry. * doc/ref/api-data.texi (Bit Vectors): Update. * libguile/array-handle.h (bitvector_ref, scm_array_get_handle): Adapt to bitvector changes. * libguile/bitvectors.h: * libguile/bitvectors.c (scm_c_bitvector_bit_is_set) (scm_c_bitvector_bit_is_clear): New functions. * libguile/deprecated.h: * libguile/deprecated.c (scm_bitvector_ref): Deprecate. * module/ice-9/sandbox.scm (bitvector-bindings): Replace bitvector-ref with bitvector-bit-set? / bitvector-bit-clear?. * module/system/vm/disassembler.scm (instruction-has-fallthrough): Use bitvector-bit-clear?. * test-suite/tests/bitvectors.test: Update. --- module/system/vm/disassembler.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'module/system/vm/disassembler.scm') diff --git a/module/system/vm/disassembler.scm b/module/system/vm/disassembler.scm index e6ce864e6..4d539a17d 100644 --- a/module/system/vm/disassembler.scm +++ b/module/system/vm/disassembler.scm @@ -509,7 +509,7 @@ address of that offset." subr-call foreign-call continuation-call j)) (let ((opcode (logand (bytevector-u32-native-ref code pos) #xff))) - (not (bitvector-ref non-fallthrough-set opcode)))) + (bitvector-bit-clear? non-fallthrough-set opcode))) (define-syntax define-jump-parser (lambda (x) -- cgit v1.2.3