diff options
author | Mark H Weaver <mhw@netris.org> | 2012-11-09 03:22:40 -0500 |
---|---|---|
committer | Mark H Weaver <mhw@netris.org> | 2012-11-09 23:05:42 -0500 |
commit | f31a0762328b9cffa328ce1540ceaa6f1497e083 (patch) | |
tree | 2644cbfe0d38285b2d575bdfcdeb26b6af48c859 /module/srfi/srfi-9.scm | |
parent | dfba1025e56245f55bdda85639e5b59682e7ad47 (diff) | |
download | guile-f31a0762328b9cffa328ce1540ceaa6f1497e083.tar.gz |
Improve error messages for invalid record definitions.
* module/srfi/srfi-9.scm (%define-record-type): Accept additional 'form'
parameter which contains the original form of 'define-record-type' or
'define-immutable-record-type'. Add elaborate pattern guard which
raises descriptive syntax errors for specific errors, and a fallback
pattern to catch anything else.
(define-record-type): Pass 'form' parameter to %define-record-type.
* module/srfi/srfi-9/gnu.scm (define-immutable-record-type): Pass 'form'
parameter to %define-record-type.
* test-suite/tests/srfi-9.test: Add tests.
Diffstat (limited to 'module/srfi/srfi-9.scm')
-rw-r--r-- | module/srfi/srfi-9.scm | 44 |
1 files changed, 37 insertions, 7 deletions
diff --git a/module/srfi/srfi-9.scm b/module/srfi/srfi-9.scm index 1dd132a7b..de4945952 100644 --- a/module/srfi/srfi-9.scm +++ b/module/srfi/srfi-9.scm @@ -205,8 +205,10 @@ (let ((name (syntax->datum field))) (or (memq name field-names) (syntax-violation - 'define-record-type - "unknown field in constructor-spec" + (syntax-case form () + ((macro . args) + (syntax->datum #'macro))) + "unknown field in constructor spec" form field)) (cons name field))) #'(field ...)))) @@ -262,9 +264,30 @@ (string-concatenate (make-list count desc)))) (syntax-case x () - ((_ immutable? type-name constructor-spec predicate-name + ((_ immutable? form type-name constructor-spec predicate-name field-spec ...) - (boolean? (syntax->datum #'immutable?)) + (let () + (define (syntax-error message subform) + (syntax-violation (syntax-case #'form () + ((macro . args) (syntax->datum #'macro))) + message #'form subform)) + (and (boolean? (syntax->datum #'immutable?)) + (or (identifier? #'type-name) + (syntax-error "expected type name" #'type-name)) + (syntax-case #'constructor-spec () + ((ctor args ...) + (every identifier? #'(ctor args ...)) + #t) + (_ (syntax-error "invalid constructor spec" + #'constructor-spec))) + (or (identifier? #'predicate-name) + (syntax-error "expected predicate name" #'predicate-name)) + (every (lambda (spec) + (syntax-case spec () + ((field getter) #t) + ((field getter setter) #t) + (_ (syntax-error "invalid field spec" spec)))) + #'(field-spec ...)))) (let* ((field-ids (field-identifiers #'(field-spec ...))) (getter-ids (getter-identifiers #'(field-spec ...))) (field-count (length field-ids)) @@ -275,7 +298,7 @@ ((ctor args ...) #'ctor))) (copier-id (make-copier-id #'type-name))) #`(begin - #,(constructor x #'type-name #'constructor-spec field-names) + #,(constructor #'form #'type-name #'constructor-spec field-names) (define type-name (let ((rtd (make-struct/no-tail @@ -296,9 +319,16 @@ #,(copier #'type-name getter-ids copier-id) #,@(if immutable? (functional-setters copier-id #'(field-spec ...)) - (setters #'type-name #'(field-spec ...))))))))) + (setters #'type-name #'(field-spec ...)))))) + ((_ immutable? form . rest) + (syntax-violation + (syntax-case #'form () + ((macro . args) (syntax->datum #'macro))) + "invalid record definition syntax" + #'form))))) (define-syntax-rule (define-record-type name ctor pred fields ...) - (%define-record-type #f name ctor pred fields ...)) + (%define-record-type #f (define-record-type name ctor pred fields ...) + name ctor pred fields ...)) ;;; srfi-9.scm ends here |