summaryrefslogtreecommitdiff
path: root/libguile/vm-i-scheme.c
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2010-10-13 01:31:19 +0200
committerLudovic Courtès <ludo@gnu.org>2010-10-13 01:31:19 +0200
commite78d4bf9a9501654024a18f8d0baa1597d57fcb8 (patch)
treebaac08c8bcab8232ff9babdad2511236ecb12b2f /libguile/vm-i-scheme.c
parentde6b3a5cb919534773e9bde571bdf500dc604eff (diff)
downloadguile-e78d4bf9a9501654024a18f8d0baa1597d57fcb8.tar.gz
Optimize `1+' and `1-' on fixnums.
* libguile/vm-i-scheme.c (INUM_MAX, INUM_MIN): New macros. (add1, sub1): Add/subtract without untagging the operand. This leads to a 44% run time improvement compared to the previous implementation. * libguile/vm.c: Include <stdint.h>. * test-suite/tests/numbers.test ("1+", "1-"): Add tests for MOST-POSITIVE-FIXNUM, resp. MOST-NEGATIVE-FIXNUM, for 32-bit and 34-bit values thereof. * benchmark-suite/benchmarks/arithmetic.bm: New file. * benchmark-suite/Makefile.am (SCM_BENCHMARKS): Add it.
Diffstat (limited to 'libguile/vm-i-scheme.c')
-rw-r--r--libguile/vm-i-scheme.c38
1 files changed, 30 insertions, 8 deletions
diff --git a/libguile/vm-i-scheme.c b/libguile/vm-i-scheme.c
index 69ea8a544..3e80a0ef5 100644
--- a/libguile/vm-i-scheme.c
+++ b/libguile/vm-i-scheme.c
@@ -209,6 +209,10 @@ VM_DEFINE_FUNCTION (149, ge, "ge?", 2)
* Numeric functions
*/
+/* The maximum/minimum tagged integers. */
+#define INUM_MAX (INTPTR_MAX - 1)
+#define INUM_MIN (INTPTR_MIN + scm_tc2_int)
+
#undef FUNC2
#define FUNC2(CFUNC,SFUNC) \
{ \
@@ -231,12 +235,21 @@ VM_DEFINE_FUNCTION (150, add, "add", 2)
VM_DEFINE_FUNCTION (151, add1, "add1", 1)
{
ARGS1 (x);
- if (SCM_I_INUMP (x))
+
+ /* Check for overflow. */
+ if (SCM_LIKELY ((scm_t_intptr) x < INUM_MAX))
{
- scm_t_int64 n = SCM_I_INUM (x) + 1;
- if (SCM_FIXABLE (n))
- RETURN (SCM_I_MAKINUM (n));
+ SCM result;
+
+ /* Add the integers without untagging. */
+ result = SCM_PACK ((scm_t_intptr) x
+ + (scm_t_intptr) SCM_I_MAKINUM (1)
+ - scm_tc2_int);
+
+ if (SCM_LIKELY (SCM_I_INUMP (result)))
+ RETURN (result);
}
+
SYNC_REGISTER ();
RETURN (scm_sum (x, SCM_I_MAKINUM (1)));
}
@@ -249,12 +262,21 @@ VM_DEFINE_FUNCTION (152, sub, "sub", 2)
VM_DEFINE_FUNCTION (153, sub1, "sub1", 1)
{
ARGS1 (x);
- if (SCM_I_INUMP (x))
+
+ /* Check for underflow. */
+ if (SCM_LIKELY ((scm_t_intptr) x > INUM_MIN))
{
- scm_t_int64 n = SCM_I_INUM (x) - 1;
- if (SCM_FIXABLE (n))
- RETURN (SCM_I_MAKINUM (n));
+ SCM result;
+
+ /* Substract the integers without untagging. */
+ result = SCM_PACK ((scm_t_intptr) x
+ - (scm_t_intptr) SCM_I_MAKINUM (1)
+ + scm_tc2_int);
+
+ if (SCM_LIKELY (SCM_I_INUMP (result)))
+ RETURN (result);
}
+
SYNC_REGISTER ();
RETURN (scm_difference (x, SCM_I_MAKINUM (1)));
}