summaryrefslogtreecommitdiff
path: root/libguile/macros.c
diff options
context:
space:
mode:
authorGreg J. Badros <gjb@cs.washington.edu>1999-12-12 02:36:16 +0000
committerGreg J. Badros <gjb@cs.washington.edu>1999-12-12 02:36:16 +0000
commit1bbd0b849f6b90f1ffe57e586e4ee5a884f84a11 (patch)
tree79120a96365e0fa3324174bfd08d731ca8311d64 /libguile/macros.c
parent6e7069385db8cf96dfbe51cf65ace161942a32c9 (diff)
downloadguile-1bbd0b849f6b90f1ffe57e586e4ee5a884f84a11.tar.gz
* *.c: Pervasive software-engineering-motivated rewrite of
function headers and argument checking. Switched SCM_PROC, SCM_PROC1 macros to be GUILE_PROC, GUILE_PROC1 (may change names later, but was useful to keep old versions around while migrate) that has docstrings and argument lists embedded in the GUILE_PROC macro invocations that expand into a function header. Use lots of new SCM_VALIDATE_* macros to simplify error checking and reduce tons of redundancy. This is very similar to what I did for Scwm. Note that none of the extraction of the docstrings, nor software engineering checks of Scwm is yet added to Guile. I'll work on that tomorrow, I expect. * Makefile.am: Added scm_validate.h to modinclude_HEADERS. * chars.c: Added docstrings for the primitives defined in here. * snarf.h: Added GUILE_PROC, GUILE_PROC1. Added SCM_REGISTER_PROC to be like old SCM_PROC, though old SCM_PROC still remains for now. Changed naming convention for the s_foo string name of the primitive to be s_scm_foo for ease of use with the macro. * scm_validate.h: Lots of new SCM_VALIDATE macros to simplify argument checking through guile. Maybe some of these should be folded into the header file for the types they check, but for now it was easiest to just stick them all in one place.
Diffstat (limited to 'libguile/macros.c')
-rw-r--r--libguile/macros.c105
1 files changed, 48 insertions, 57 deletions
diff --git a/libguile/macros.c b/libguile/macros.c
index c7b9af06b..ac9485ab5 100644
--- a/libguile/macros.c
+++ b/libguile/macros.c
@@ -38,72 +38,71 @@
* If you write modifications of your own for GUILE, it is your choice
* whether to permit this exception to apply to your modifications.
* If you do not wish that, delete this exception notice. */
+
+/* Software engineering face-lift by Greg J. Badros, 11-Dec-1999,
+ gjb@cs.washington.edu, http://www.cs.washington.edu/homes/gjb */
+
#include "_scm.h"
#include "smob.h"
+#include "scm_validate.h"
#include "macros.h"
long scm_tc16_macro;
-SCM_PROC(s_makacro, "procedure->syntax", 1, 0, 0, scm_makacro);
-
-SCM
-scm_makacro (code)
- SCM code;
+GUILE_PROC (scm_makacro, "procedure->syntax", 1, 0, 0,
+ (SCM code),
+"")
+#define FUNC_NAME s_scm_makacro
{
- SCM_ASSERT (SCM_NFALSEP (scm_procedure_p (code)),
- code, SCM_ARG1, s_makacro);
+ SCM_VALIDATE_PROC(1,code);
SCM_RETURN_NEWSMOB (scm_tc16_macro, code);
}
+#undef FUNC_NAME
-SCM_PROC(s_makmacro, "procedure->macro", 1, 0, 0, scm_makmacro);
-
-SCM
-scm_makmacro (code)
- SCM code;
+GUILE_PROC(scm_makmacro, "procedure->macro", 1, 0, 0,
+ (SCM code),
+"")
+#define FUNC_NAME s_scm_makmacro
{
- SCM_ASSERT (SCM_NFALSEP (scm_procedure_p (code)),
- code, SCM_ARG1, s_makmacro);
+ SCM_VALIDATE_PROC(1,code);
SCM_RETURN_NEWSMOB (scm_tc16_macro | (1L << 16), code);
}
+#undef FUNC_NAME
-SCM_PROC(s_makmmacro, "procedure->memoizing-macro", 1, 0, 0, scm_makmmacro);
-
-SCM
-scm_makmmacro (code)
- SCM code;
+GUILE_PROC(scm_makmmacro, "procedure->memoizing-macro", 1, 0, 0,
+ (SCM code),
+"")
+#define FUNC_NAME s_scm_makmmacro
{
- SCM_ASSERT (SCM_NFALSEP (scm_procedure_p (code)),
- code, SCM_ARG1, s_makmmacro);
+ SCM_VALIDATE_PROC(1,code);
SCM_RETURN_NEWSMOB (scm_tc16_macro | (2L << 16), code);
}
+#undef FUNC_NAME
-SCM_PROC (s_macro_p, "macro?", 1, 0, 0, scm_macro_p);
-
-SCM
-scm_macro_p (obj)
- SCM obj;
+GUILE_PROC (scm_macro_p, "macro?", 1, 0, 0,
+ (SCM obj),
+"")
+#define FUNC_NAME s_scm_macro_p
{
- return (SCM_NIMP (obj) && SCM_TYP16 (obj) == scm_tc16_macro
- ? SCM_BOOL_T
- : SCM_BOOL_F);
+ return SCM_BOOL(SCM_NIMP (obj) && SCM_TYP16 (obj) == scm_tc16_macro);
}
+#undef FUNC_NAME
SCM_SYMBOL (scm_sym_syntax, "syntax");
SCM_SYMBOL (scm_sym_macro, "macro");
SCM_SYMBOL (scm_sym_mmacro, "macro!");
-SCM_PROC (s_macro_type, "macro-type", 1, 0, 0, scm_macro_type);
-
-SCM
-scm_macro_type (m)
- SCM m;
+GUILE_PROC (scm_macro_type, "macro-type", 1, 0, 0,
+ (SCM m),
+"")
+#define FUNC_NAME s_scm_macro_type
{
if (!(SCM_NIMP (m) && SCM_TYP16 (m) == scm_tc16_macro))
return SCM_BOOL_F;
@@ -112,43 +111,35 @@ scm_macro_type (m)
case 0: return scm_sym_syntax;
case 1: return scm_sym_macro;
case 2: return scm_sym_mmacro;
- default: scm_wrong_type_arg (s_macro_type, 1, m);
+ default: scm_wrong_type_arg (FUNC_NAME, 1, m);
}
}
+#undef FUNC_NAME
-SCM_PROC (s_macro_name, "macro-name", 1, 0, 0, scm_macro_name);
-
-SCM
-scm_macro_name (m)
- SCM m;
+GUILE_PROC (scm_macro_name, "macro-name", 1, 0, 0,
+ (SCM m),
+"")
+#define FUNC_NAME s_scm_macro_name
{
- SCM_ASSERT (SCM_NIMP (m) && SCM_TYP16 (m) == scm_tc16_macro,
- m,
- SCM_ARG1,
- s_macro_name);
+ SCM_VALIDATE_SMOB(1,m,macro);
return scm_procedure_name (SCM_CDR (m));
}
+#undef FUNC_NAME
-SCM_PROC (s_macro_transformer, "macro-transformer", 1, 0, 0, scm_macro_transformer);
-
-SCM
-scm_macro_transformer (m)
- SCM m;
+GUILE_PROC (scm_macro_transformer, "macro-transformer", 1, 0, 0,
+ (SCM m),
+"")
+#define FUNC_NAME s_scm_macro_transformer
{
- SCM_ASSERT (SCM_NIMP (m) && SCM_TYP16 (m) == scm_tc16_macro,
- m,
- SCM_ARG1,
- s_macro_transformer);
+ SCM_VALIDATE_SMOB(1,m,macro);
return SCM_CLOSUREP (SCM_CDR (m)) ? SCM_CDR (m) : SCM_BOOL_F;
}
+#undef FUNC_NAME
SCM
-scm_make_synt (name, macroizer, fcn)
- const char *name;
- SCM (*macroizer) ();
- SCM (*fcn) ();
+scm_make_synt (const char *name, SCM (*macroizer) (), SCM (*fcn)() )
{
SCM symcell = scm_sysintern (name, SCM_UNDEFINED);
long tmp = ((((SCM_CELLPTR) (SCM_CAR (symcell))) - scm_heap_org) << 8);