diff options
author | Andy Wingo <wingo@pobox.com> | 2012-02-05 15:55:09 +0100 |
---|---|---|
committer | Andy Wingo <wingo@pobox.com> | 2012-02-05 15:55:37 +0100 |
commit | 817307ccac5027fd784798bbbf6ffb52e0a5d751 (patch) | |
tree | 2ff2e6316b36d709e442f52255c92ec5262ebb6e /libguile/gc-malloc.c | |
parent | 13fb25ba0c24a9e7732d2c32dbc882c7d462bce9 (diff) | |
download | guile-817307ccac5027fd784798bbbf6ffb52e0a5d751.tar.gz |
Fix --enable-debug-malloc
* libguile/gc-malloc.c (do_realloc, do_calloc, do_gc_malloc)
(do_gc_malloc_atomic, do_gc_realloc, do_gc_free): Wrap the allocators
in helper methods. The non-GC allocators call
scm_gc_register_allocation, and the GC allocators ensure that
gc_malloc returns a nonzero value.
(scm_realloc, scm_calloc): Allow NULL return for malloc(0). It is
permitted by POSIX. Don't wrap in a SCM_SYSCALL; the only possible
errno is ENOMEM.
(scm_gc_malloc_pointerless, scm_gc_malloc, scm_gc_calloc):
(scm_gc_realloc, scm_gc_free, scm_gc_strndump): Use the wrappers.
Don't call the debug-malloc registrations and deregistrations, as it
is neither mandatory nor advised to call scm_gc_free. Fixes
compilation with debug-malloc.
(scm_must_free): Don't scm_malloc_unregister.
Diffstat (limited to 'libguile/gc-malloc.c')
-rw-r--r-- | libguile/gc-malloc.c | 93 |
1 files changed, 56 insertions, 37 deletions
diff --git a/libguile/gc-malloc.c b/libguile/gc-malloc.c index de8e9e2b3..2aff4c31a 100644 --- a/libguile/gc-malloc.c +++ b/libguile/gc-malloc.c @@ -1,5 +1,5 @@ /* Copyright (C) 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, - * 2004, 2006, 2008, 2009, 2010, 2011 Free Software Foundation, Inc. + * 2004, 2006, 2008, 2009, 2010, 2011, 2012 Free Software Foundation, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public License @@ -78,6 +78,49 @@ extern unsigned long * __libc_ia64_register_backing_store_base; + +static void* +do_realloc (void *from, size_t new_size) +{ + scm_gc_register_allocation (new_size); + return realloc (from, new_size); +} + +static void* +do_calloc (size_t n, size_t size) +{ + scm_gc_register_allocation (size); + return calloc (n, size); +} + +static void* +do_gc_malloc (size_t size, const char *what) +{ + /* Ensure nonzero size to be compatible with always-nonzero return of + glibc malloc. */ + return GC_MALLOC (size ? size : sizeof (void *)); +} + +static void* +do_gc_malloc_atomic (size_t size, const char *what) +{ + return GC_MALLOC_ATOMIC (size ? size : sizeof (void *)); +} + +static void* +do_gc_realloc (void *from, size_t size, const char *what) +{ + return GC_REALLOC (from, size ? size : sizeof (void *)); +} + +static void +do_gc_free (void *ptr) +{ + GC_FREE (ptr); +} + + + /* Function for non-cell memory management. */ @@ -86,10 +129,9 @@ scm_realloc (void *mem, size_t size) { void *ptr; - scm_gc_register_allocation (size); + ptr = do_realloc (mem, size); - SCM_SYSCALL (ptr = realloc (mem, size)); - if (ptr) + if (ptr || size == 0) return ptr; /* Time is hard: trigger a full, ``stop-the-world'' GC, and try again. */ @@ -99,7 +141,7 @@ scm_realloc (void *mem, size_t size) GC_gcollect (); #endif - SCM_SYSCALL (ptr = realloc (mem, size)); + ptr = do_realloc (mem, size); if (ptr) return ptr; @@ -125,8 +167,8 @@ scm_calloc (size_t sz) By default, try to use calloc, as it is likely more efficient than calling memset by hand. */ - SCM_SYSCALL (ptr = calloc (sz, 1)); - if (ptr) + ptr = do_calloc (sz, 1); + if (ptr || sz == 0) return ptr; ptr = scm_realloc (NULL, sz); @@ -181,57 +223,38 @@ scm_gc_unregister_collectable_memory (void *mem, size_t size, const char *what) void * scm_gc_malloc_pointerless (size_t size, const char *what) { - return GC_MALLOC_ATOMIC (size); + return do_gc_malloc_atomic (size, what); } void * scm_gc_malloc (size_t size, const char *what) { - void *ptr; - - if (size == 0) - /* `GC_MALLOC ()' doesn't handle zero. */ - size = sizeof (void *); - - ptr = GC_MALLOC (size); - - return ptr; + return do_gc_malloc (size, what); } void * scm_gc_calloc (size_t size, const char *what) { /* `GC_MALLOC ()' always returns a zeroed buffer. */ - return scm_gc_malloc (size, what); + return do_gc_malloc (size, what); } - void * scm_gc_realloc (void *mem, size_t old_size, size_t new_size, const char *what) { - void *ptr; - - ptr = GC_REALLOC (mem, new_size); - -#ifdef GUILE_DEBUG_MALLOC - if (mem) - scm_malloc_reregister (mem, ptr, what); -#endif - - return ptr; + return do_gc_realloc (mem, new_size, what); } void scm_gc_free (void *mem, size_t size, const char *what) { - scm_gc_unregister_collectable_memory (mem, size, what); - GC_FREE (mem); + do_gc_free (mem); } char * scm_gc_strndup (const char *str, size_t n, const char *what) { - char *dst = GC_MALLOC_ATOMIC (n + 1); + char *dst = do_gc_malloc_atomic (n + 1, what); memcpy (dst, str, n); dst[n] = 0; return dst; @@ -309,11 +332,7 @@ scm_must_free (void *obj) ("scm_must_free is deprecated. " "Use scm_gc_malloc and scm_gc_free instead."); -#ifdef GUILE_DEBUG_MALLOC - scm_malloc_unregister (obj); -#endif - - GC_FREE (obj); + do_gc_free (obj); } #undef FUNC_NAME |