summaryrefslogtreecommitdiff
path: root/libguile/bytevectors.c
diff options
context:
space:
mode:
authorAndy Wingo <wingo@pobox.com>2010-12-04 19:31:20 +0100
committerAndy Wingo <wingo@pobox.com>2010-12-04 19:31:20 +0100
commit3ef6650def28f7c29a2cc983086468d3195167d4 (patch)
tree17d477ff5489b1c29796495e8af32edb01a6ec77 /libguile/bytevectors.c
parent8556760c234b75e1faba956ba7b3b44175783459 (diff)
downloadguile-3ef6650def28f7c29a2cc983086468d3195167d4.tar.gz
make-string et al nulls memory if not given an initializer
* libguile/gc-malloc.c: Add a note that the gc-malloc does not clear the memory block, so users need to make sure it is initialized. * libguile/bitvectors.c (scm_c_make_bitvector): * libguile/bytevectors.c (scm_make_bytevector): * libguile/strings.c (scm_c_make_string): If no initializer is given, initialize the bytes to 0. Prevents information leakage if an app uses make-string et al without initializers. * libguile/foreign.c (make_cif): Initialize this too, to prevent leakage in the struct holes. Paranoia...
Diffstat (limited to 'libguile/bytevectors.c')
-rw-r--r--libguile/bytevectors.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libguile/bytevectors.c b/libguile/bytevectors.c
index 31703bf2e..30adbff57 100644
--- a/libguile/bytevectors.c
+++ b/libguile/bytevectors.c
@@ -482,6 +482,8 @@ SCM_DEFINE (scm_make_bytevector, "make-bytevector", 1, 1, 0,
for (i = 0; i < c_len; i++)
contents[i] = c_fill;
}
+ else
+ memset (SCM_BYTEVECTOR_CONTENTS (bv), 0, c_len);
return bv;
}