summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2010-02-15 16:10:01 +0100
committerLudovic Courtès <ludo@gnu.org>2010-02-15 16:10:01 +0100
commit25bc75c4316497c95b1c3fc17f1678ac47d32041 (patch)
tree348b7f2b745b6f0ff52e7b48071b031ad7c5229a
parent2fe5eb561c02ceda6e9244e14c68b2072fb94eb5 (diff)
downloadguile-25bc75c4316497c95b1c3fc17f1678ac47d32041.tar.gz
Fix `getaddrinfo' tests.
Thanks to Ken Raeburn. * test-suite/tests/net-db.test ("getaddrinfo")["port 80"]: Fix bogus check of `addrinfo:flags' (POSIX says that the "contents of the ai_flags field of the returned structures are undefined."). ("wrong service name"): Accept `EAI_NONAME' as a valid error code.
-rw-r--r--test-suite/tests/net-db.test6
1 files changed, 4 insertions, 2 deletions
diff --git a/test-suite/tests/net-db.test b/test-suite/tests/net-db.test
index 23a534d9a..7364d82ad 100644
--- a/test-suite/tests/net-db.test
+++ b/test-suite/tests/net-db.test
@@ -50,7 +50,6 @@
(fold (lambda (ai ok?)
(let ((sa (addrinfo:addr ai)))
(and ok?
- (> (logand (addrinfo:flags ai) AI_ADDRCONFIG) 0)
(= (sockaddr:port sa) 80))))
#t
ai))))
@@ -73,5 +72,8 @@
(getaddrinfo "127.0.0.1" "does-not-exist" AI_NUMERICHOST)
#f)
(lambda (key errcode)
- (and (= errcode EAI_SERVICE)
+ ;; According to POSIX, both error codes are valid (glibc 2.11
+ ;; chooses `EAI_SERVICE'; Darwin chooses `EAI_NONAME'.)
+ (and (or (= errcode EAI_SERVICE)
+ (= errcode EAI_NONAME))
(string? (gai-strerror errcode))))))))